Open
Conversation
clue
requested changes
Apr 20, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Motivation unclear, unlike reactphp/promise#138 this seemingly doesn't appear to provide any value to consumers of this library and may limit adoption of future versions.
Not saying it doesn't make sense and even more so not suggesting that using outdated PHP versions is a good idea, but this PR currently poorly communicates why we should accept it. If we want this, then we should clearly communicate the motivation and how this may or may not conflict with ReactPHP's project goals (see homepage) and LTS promise.
This was referenced May 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As one of the goals for
v0.2.0is to drop PHP 5.x support, this PR lays the foundation for that by dropping the PHP 5.x versions from TravisCI and changing the composer enforced version to 7+.